Use current time instead of hardcoded value as random seed #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3w
reviewed
Dec 23, 2021
| @@ -95,7 +95,7 @@ void Cloud::Reset() { | |||
| droplet.Reset(); | |||
|
|
|||
| // Reset all the RNG stuff | |||
| mt.seed(0x1234567); | |||
| mt.seed(high_resolution_clock::now().time_since_epoch().count()); | |||
There was a problem hiding this comment.
Hello @xV8IHmeZIAStqNFV8iKGyyertVIet15TS6gWrIV,
tl;dr Add a static_cast<uint32_t>, and this should be fine.
I made this deterministic to make it easier to debug things during development. I have no objections to making it truly random now.
However, count() will return a 64-bit unsigned integer, but seed() takes a 32-bit unsigned integer (mt19937 takes a 32-bit seed, mt19937_64 takes a 64-bit seed). So some compilers will warn that this operation performs an implicit narrowing conversion. If you add a static_cast<uint32_t>, then it will be fine.
A better approach would be something like:
random_device rd;
seed_seq sseq{rd(), rd()}; // 64-bits of random state used for seeding
mt.seed(sseq);Edit: Also, I will be away from my development computer until Jan 10th. So this won't get merged for a while...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the random seed is hard coded to be 0x1234567, which leads to the output being exactly the same every time you reset it by pressing the space bar.